mobile/responsive CSS #7

New Issue

Open

opened 2023-08-23 09:51:04 +02:00 by Arnaudv6 · 1 comment

Arnaudv6 commented

2023-08-23 09:51:04 +02:00

Hi, I heard of your project on linuxfr.org, just created an account and read the contribution file.
I'm a Node rookie. My goal is to improve ux/css for mobile (my CSS dates back 2020s, don't expect fireworks).
side notes: I also propose updating gittea project's subtitle, as gitlab is no longer upstream,
and would rename those dirs for consistency:
public -> assets
bin -> deploy
I'm french and you can call me for quick chat, you'll find my number here: https://arnaudv6.gitlab.io
++

Hi, I heard of your project on linuxfr.org, just created an account and read the contribution file. I'm a Node rookie. My goal is to improve ux/css for mobile (my CSS dates back 2020s, don't expect fireworks). side notes: I also propose updating gittea project's subtitle, as gitlab is no longer upstream, and would rename those dirs for consistency: public -> assets bin -> deploy I'm french and you can call me for quick chat, you'll find my number here: https://arnaudv6.gitlab.io ++

raph commented

2023-08-23 14:54:11 +02:00

Owner

Hi Arnaud and welcome!

Feel free to submit merge requests to improve ux/css on mobile :-) I'd be more than happy to welcome contributions on this project. If you need guidance please ask.

As for the directory renaming, I'm softly against:

you'll surprise / disrupt people who already have deployed trivabble and raise their maintenance burden. People will need to update their webserver config, or even they docker files.
you'll force us to write a migration guide
while your new names may look better (though it's a matter of taste) and more conventional (which is usually better, I agree!), the consequences of the renaming don't seem worth it, I think we can live with the current names with no real drawbacks.
on a personal front, I do actually prefer "public" than "assets". I think that assets is usually more used for things like css and javascript files. Here, the main page ("index.html") is also in "public", and I think the name "public" reflects this better.

If you still want to discuss about this despite this, I invite you to open a separate ticket about this so we don't mix the discussions. I won't hide that you'll need some strong arguments for the renaming to convince me (as in: "assets" looks better than "public" is not enough :-)).

For the record, this directory layout was implemented by Laurent Mazet, you can see the full history here https://gitlab.com/raphj/trivabble/-/issues/1
I hope you'll fully understand my concerns here.

Good catch for the project subtitle. Actually this is not really the subtitle, this display was caused by the fact this repository was set as an actual mirror of the gitlab repository. I just converted the mirror to a standard repository. Thanks.

Hi Arnaud and welcome! Feel free to submit merge requests to improve ux/css on mobile :-) I'd be more than happy to welcome contributions on this project. If you need guidance please ask. As for the directory renaming, I'm softly against: - you'll surprise / disrupt people who already have deployed trivabble and raise their maintenance burden. People will need to update their webserver config, or even they docker files. - you'll force us to write a migration guide - while your new names may look better (though it's a matter of taste) and more conventional (which is usually better, I agree!), the consequences of the renaming don't seem worth it, I think we can live with the current names with no real drawbacks. - on a personal front, I do actually prefer "public" than "assets". I think that assets is usually more used for things like css and javascript files. Here, the main page ("index.html") is also in "public", and I think the name "public" reflects this better. If you still want to discuss about this despite this, I invite you to open a separate ticket about this so we don't mix the discussions. I won't hide that you'll need some strong arguments for the renaming to convince me (as in: "assets" looks better than "public" is not enough :-)). For the record, this directory layout was implemented by Laurent Mazet, you can see the full history here https://gitlab.com/raphj/trivabble/-/issues/1 I hope you'll fully understand my concerns here. Good catch for the project subtitle. Actually this is not really the subtitle, this display was caused by the fact this repository was set as an actual mirror of the gitlab repository. I just converted the mirror to a standard repository. Thanks.

👍 1

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: trivabble/trivabble#7

No description provided.